feat/new vaults table #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
peterslany
force-pushed
the
peter/feat-new-vaults-table
branch
from
f013e86
to
209fdfb
Compare
tomjeatt
reviewed
Jun 27, 2022
There was a problem hiding this comment.
Looks really good @peterslany :) - couple of comments/questions, but not necessarily change requests.
Thanks for the review @tomjeatt! I pushed some updates so feel free to re-review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
TableandNewVaultsTablecomponent. This component displays information about current and upcoming vaults. The table is responsive: when screen is smaller than table, horizontal scrolling is activated. The columns of table are scaled to full width by default.Note: The CTA is invisible on Interlay since it doesn't have styling defined for Interlay secondary variant yet, once we define it the CTA will display styled without any needs to update the vaults table component.