Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct issue/redeem period calculations #341

Merged
merged 10 commits into from
Jun 15, 2022
Merged

fix: correct issue/redeem period calculations #341

merged 10 commits into from
Jun 15, 2022

Conversation

crypto-engineer
Copy link
Contributor

@crypto-engineer crypto-engineer commented Jun 14, 2022 •
edited
Loading

Capture

  • Correct issue period calculation.
  • Correct redeem period calculation.
  • Clean up unnecessary redux mechanisms which were used for managing issue period.

@crypto-engineer crypto-engineer added bug Something isn't working enhancement New feature or request labels Jun 14, 2022
@crypto-engineer crypto-engineer self-assigned this Jun 14, 2022
@vercel
Copy link

vercel bot commented Jun 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 10:18PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 10:18PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 10:18PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 10:18PM (UTC)

@crypto-engineer crypto-engineer marked this pull request as draft June 14, 2022 21:14
@github-actions
Copy link

Running Lighthouse audit...

@crypto-engineer crypto-engineer marked this pull request as ready for review June 15, 2022 08:13
@crypto-engineer crypto-engineer requested review from theodorebugnet and tomjeatt and removed request for theodorebugnet and tomjeatt June 15, 2022 08:14
@crypto-engineer crypto-engineer changed the title fix: correct redeem period calculation fix: correct issue/redeem period calculations Jun 15, 2022
peterslany
peterslany approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@crypto-engineer crypto-engineer merged commit eb3cae6 into interlay:master Jun 15, 2022
@crypto-engineer crypto-engineer deleted the bugfix/redeem-period branch June 15, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterslany peterslany peterslany approved these changes

@theodorebugnet theodorebugnet Awaiting requested review from theodorebugnet

@tomjeatt tomjeatt Awaiting requested review from tomjeatt

Assignees

@crypto-engineer crypto-engineer

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crypto-engineer @peterslany