Tom/info component #344
Merged
Tom/info component #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/componentLibrary/theme/theme.kintsugi.css # src/componentLibrary/theme/theme.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
|
Deployment failed with the following error: |
This reverts commit 52815ee.
peterslany
reviewed
Jun 20, 2022
There was a problem hiding this comment.
Hi @tomjeatt, very nice and simple solution :) Left just a little comment there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an info box component. This uses the primary CTA to avoid creating an outline CTA variant (discussed this with Jay and he didn't want to introduce the additional variant).
This component renders at full width; when used, it will be constrained and positioned by the parent element. A CTA will be rendered if a
ctaOnClickprop is passed.