Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peter/fix prepare interlay #353

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Peter/fix prepare interlay #353

merged 6 commits into from
Jun 22, 2022

Conversation

peterslany
Copy link
Contributor

Preparing full interlay dApp launch:

  • changed interBTC -> IBTC
  • added color shades for interlay theme: colors were darkened to create more contrast and improve UX

before
image

after adjusting colors for Interlay
image

@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:16AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:16AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:16AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:16AM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please look into tailwindcss rule related issues?

src/utils/helpers/colors.ts Outdated Show resolved Hide resolved
src/utils/helpers/colors.ts Outdated Show resolved Hide resolved
src/utils/helpers/colors.ts Outdated Show resolved Hide resolved
@peterslany
Copy link
Contributor Author

Could you please look into tailwindcss rule related issues?

Hi @crypto-engineer, thanks for the review and pointing out the problem with dynamic concatenation of classes! I reafactored the PR and used static definition of classes instead, feel free to re-review :)

Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants