Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/some hooks #357

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

crypto-engineer
Copy link
Contributor

@crypto-engineer crypto-engineer commented Jun 24, 2022

Replace some repetitive hooks with useStableBitcoinConfirmations, useCurrentActiveBlockNumber, and useStableParachainConfirmations.
This is a straightforward PR.

@vercel
Copy link

vercel bot commented Jun 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 7:44PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 7:44PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 7:44PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 7:44PM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

@crypto-engineer crypto-engineer self-assigned this Jun 28, 2022
@crypto-engineer crypto-engineer added the enhancement New feature or request label Jun 28, 2022
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - at some point I'd like to pull these together into a single hook, but that's not high priority and this is a really good step along the way. Thanks :)

@crypto-engineer crypto-engineer merged commit 76513a1 into interlay:master Jun 28, 2022
@crypto-engineer crypto-engineer deleted the refactor/some-hooks branch June 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants