Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tom/cta bug fix #361

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Tom/cta bug fix #361

merged 3 commits into from
Jun 29, 2022

Conversation

tomjeatt
Copy link
Collaborator

@tomjeatt tomjeatt commented Jun 29, 2022

CTALink component renders a router link instead of an anchor tag, which prevents the application re-rendering unnecessarily.

@vercel
Copy link

vercel bot commented Jun 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 0:00AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 0:00AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 0:00AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 0:00AM (UTC)

@tomjeatt tomjeatt marked this pull request as ready for review June 29, 2022 10:33
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix of the CTA link @tomjeatt :) Just one question about the leftover href prop.

src/componentLibrary/CTA/CTALink.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

Running Lighthouse audit...

Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@tomjeatt tomjeatt merged commit 0245e55 into master Jun 29, 2022
@tomjeatt tomjeatt deleted the tom/cta-bug-fix branch June 29, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants