Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get pending redeems #364

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fix: get pending redeems #364

merged 1 commit into from
Jul 1, 2022

Conversation

tomjeatt
Copy link
Collaborator

@tomjeatt tomjeatt commented Jul 1, 2022

Get pending redeem requests

@vercel
Copy link

vercel bot commented Jul 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:42PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:42PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:42PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:42PM (UTC)

@tomjeatt tomjeatt marked this pull request as ready for review July 1, 2022 13:49
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution :) However it's diverging from the ticket a little, I think it would be good to discuss whether to display both pending issue and redeem requests or redeem requests only. @tomjeatt @sander2 cc @alexbleau

src/utils/hooks/api/get-vault-overview.ts Show resolved Hide resolved
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you @tomjeatt, we can easily change it later - if needed - after the discussion with others :)

@tomjeatt tomjeatt merged commit 6fcde96 into master Jul 1, 2022
@tomjeatt tomjeatt deleted the tom/vault-card-redeems branch July 1, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants