Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use transient props to resolve react error #365

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

tomjeatt
Copy link
Collaborator

@tomjeatt tomjeatt commented Jul 1, 2022

This fixes a React error by using transient props to avoid custom props being passed down to the dom element

@vercel
Copy link

vercel bot commented Jul 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:55PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:55PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:55PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 1:55PM (UTC)

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Running Lighthouse audit...

Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I noticed the warning about the fullWidth attribute in console, but didn't get to looking into it :)

@tomjeatt tomjeatt merged commit f6da274 into master Jul 1, 2022
@tomjeatt tomjeatt deleted the tom/cta-react-error branch July 4, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants