Feature/base input #367
Merged
Feature/base input #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
tomjeatt
reviewed
Jul 5, 2022
peterslany
reviewed
Jul 5, 2022
tomjeatt
requested changes
Jul 5, 2022
There was a problem hiding this comment.
HI @crypto-engineer looks good :) few questions, but the only really important comment is the one about the focus state. It's such a quick change that I'd prefer that you speak to Jay so that we can get it in now, rather than adding it to the backlog.
crypto-engineer
commented
Jul 5, 2022
tomjeatt
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Looks great @crypto-engineer - think there's one tiny thing to tidy up, but apart from that it's good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: there are a lot of file changes but many of them were made by running prettier and very minor.
This PR includes:
Because these components are developed based on Inversion of Control, composition and primitives, they can be used with any form handling libs.