Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peter/feat tx fee fetching #373

Merged
merged 9 commits into from
Jul 14, 2022
Merged

Peter/feat tx fee fetching #373

merged 9 commits into from
Jul 14, 2022

Conversation

peterslany
Copy link
Contributor

Adding fetching of transaction fee reserve amount from RPC instead of using hard-coded value.

@vercel
Copy link

vercel bot commented Jul 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 8:53AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 8:53AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 8:53AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 8:53AM (UTC)

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Running Lighthouse audit...

@crypto-engineer
Copy link
Contributor

Let me review it.

src/pages/Staking/index.tsx Outdated Show resolved Hide resolved
src/pages/Staking/index.tsx Outdated Show resolved Hide resolved
src/pages/Staking/index.tsx Outdated Show resolved Hide resolved
@peterslany
Copy link
Contributor Author

Thanks for the review and suggestions @crypto-engineer! I moved the fetcher into its own react-query function :)

Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left some comments though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants