Tom/vault error #377
Merged
Tom/vault error #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
1 similar comment
|
Running Lighthouse audit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix here is bumping the lib and filtering out the null data. There are more instances of filter than I would like, which is because of a related bug that triggers an error when switching accounts. This is outside of the scope of this ticket, but I think we need to address it so I've added a ticket to sprint 42:
https://www.notion.so/interlay/Reset-application-state-on-account-change-6b44601120d14b999ab81c7804ff3bee
Note: we could handle the above by using the address from state, but that causes a mismatch between the account address in the URL and the data, which is one reason I'd prefer to leave the behaviour as it is for now and address the issue properly.