Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add max balance buttons #388

Merged
merged 2 commits into from
Jul 15, 2022
Merged

feat: add max balance buttons #388

merged 2 commits into from
Jul 15, 2022

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Jul 14, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Jul 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 10:43AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 10:43AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 10:43AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 10:43AM (UTC)

@danielsimao danielsimao marked this pull request as draft July 14, 2022 14:10
@github-actions
Copy link

Running Lighthouse audit...

@danielsimao danielsimao marked this pull request as ready for review July 14, 2022 16:35
@danielsimao danielsimao changed the title feat: add apply max balance funcionality feat: add max balance buttons Jul 14, 2022
tomjeatt
tomjeatt reviewed Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielsimao changes look good - no specific change requests, but a couple of comments to take a look at :)

src/components/AvailableBalanceUI/index.tsx Show resolved Hide resolved
src/pages/Staking/index.tsx Show resolved Hide resolved
src/pages/Transfer/CrossChainTransferForm/index.tsx Show resolved Hide resolved
src/pages/Transfer/CrossChainTransferForm/index.tsx Show resolved Hide resolved
tomjeatt
tomjeatt approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :) thanks for addressing the comments

@danielsimao danielsimao merged commit d11d518 into master Jul 15, 2022
@danielsimao danielsimao deleted the rui/apply-max-balance branch July 15, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielsimao @tomjeatt