fix(bridge): redeem error mismatch #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
crypto-engineer
requested review from
crypto-engineer
and removed request for
anton-karlovskiy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves this ticket.
The problem was that the
validateFormfunction is calledonChangeof the Input. TheredeemFeecalculation needs the current input value, meaning that it has a direct dependency to it. When callingvalidateForm, this function was using the most recent input value, while theredeemFeewas still using the previous input value. Thus, creating a state sync issue. The quickest and simpler solution was bring the calculation insidevalidateFormin order to use the most recent input value instead.Here is a video of the end result.