Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/success icons #391

Merged
merged 10 commits into from
Jul 19, 2022
Merged

Feature/success icons #391

merged 10 commits into from
Jul 19, 2022

Conversation

crypto-engineer
Copy link
Contributor

Capture

@crypto-engineer crypto-engineer self-assigned this Jul 17, 2022
@vercel
Copy link

vercel bot commented Jul 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 7:34PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 7:34PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 7:34PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 7:34PM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

1 similar comment
@github-actions
Copy link

Running Lighthouse audit...

peterslany
peterslany suggested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @crypto-engineer, the code looks good to me 👍 However, I suggest we only extend the existing general Icon component we already have in the component library for this use case. I noticed you also modified this general Icon component so it contains the checkmark variant. Therefore - is there any reason for keeping the checkmark icon as a separate component please?

src/component-library/CheckCircleIcon/CheckCircleIcon.stories.tsx Outdated Show resolved Hide resolved
@peterslany
Copy link
Contributor

Also, why is this PR to be merged into Interlay production please?

@crypto-engineer
Copy link
Contributor Author

crypto-engineer commented Jul 18, 2022 •
edited
Loading

Also, why is this PR to be merged into Interlay production please?

@peterslany
It's pointed to master. The prefixed interlay is the repo name since I forked.

@crypto-engineer
Copy link
Contributor Author

@peterslany
Could you please review it again? Thanks.

peterslany
peterslany approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates 👍

@crypto-engineer crypto-engineer merged commit e584d49 into interlay:master Jul 19, 2022
@crypto-engineer crypto-engineer deleted the feature/success-icons branch July 19, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsimao danielsimao danielsimao approved these changes

@peterslany peterslany peterslany approved these changes

@tomjeatt tomjeatt Awaiting requested review from tomjeatt

Assignees

@crypto-engineer crypto-engineer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crypto-engineer @peterslany @danielsimao