Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NumberInput): remake with react aria and stately #397

Merged
merged 2 commits into from
Jul 22, 2022
Merged

refactor(NumberInput): remake with react aria and stately #397

merged 2 commits into from
Jul 22, 2022

Conversation

danielsimao
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jul 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 1:20PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 1:20PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 1:20PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 1:20PM (UTC)

@danielsimao danielsimao marked this pull request as draft July 21, 2022 10:04
@danielsimao danielsimao changed the title Rui/poc number input hook form POC - NumberInput Jul 21, 2022
@github-actions
Copy link

Running Lighthouse audit...

@danielsimao danielsimao force-pushed the rui/poc-number-input-hook-form branch from bc89f74 to ca13a78 Compare July 21, 2022 15:36
@danielsimao danielsimao marked this pull request as ready for review July 21, 2022 15:37
@danielsimao danielsimao force-pushed the rui/poc-number-input-hook-form branch from ca13a78 to 1b4a510 Compare July 21, 2022 15:41
@danielsimao danielsimao force-pushed the rui/poc-number-input-hook-form branch from 1b4a510 to d2ea723 Compare July 21, 2022 15:52
@danielsimao danielsimao changed the title POC - NumberInput refactor(NumberInput): remake with react aria and stately Jul 21, 2022
@danielsimao danielsimao force-pushed the rui/poc-number-input-hook-form branch 2 times, most recently from f32b180 to ee5901d Compare July 21, 2022 15:57
@danielsimao danielsimao force-pushed the rui/poc-number-input-hook-form branch from ee5901d to 48f8f96 Compare July 22, 2022 11:16
@danielsimao danielsimao added the enhancement New feature or request label Jul 22, 2022
tomjeatt
tomjeatt approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you :) a couple of minor comments. May or may not need changes, but doesn't need to be reviewed again.

src/component-library/NumberInput/NumberInput.style.tsx Outdated Show resolved Hide resolved
src/component-library/NumberInput/NumberInput.tsx Outdated Show resolved Hide resolved
src/component-library/utils/chain.ts Outdated Show resolved Hide resolved
@danielsimao danielsimao merged commit ceb8c44 into master Jul 22, 2022
@danielsimao danielsimao deleted the rui/poc-number-input-hook-form branch July 22, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielsimao @tomjeatt