Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/governance token balance #400

Merged
merged 35 commits into from
Jul 27, 2022
Merged

Refactor/governance token balance #400

merged 35 commits into from
Jul 27, 2022

Conversation

crypto-engineer
Copy link
Contributor

@crypto-engineer crypto-engineer commented Jul 22, 2022 •
edited
Loading

  • Implement:
    • useGovernanceTokenBalance
    • useTokenBalance
  • Replace governance token balance management by redux with the above hooks.
  • Drop governance token balance management by redux.

@crypto-engineer crypto-engineer self-assigned this Jul 22, 2022
@vercel
Copy link

vercel bot commented Jul 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 8:48AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 8:48AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 8:48AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 8:48AM (UTC)

@crypto-engineer crypto-engineer marked this pull request as draft July 22, 2022 06:38
@github-actions
Copy link

Running Lighthouse audit...

@crypto-engineer crypto-engineer added the enhancement New feature or request label Jul 22, 2022
@crypto-engineer crypto-engineer marked this pull request as ready for review July 22, 2022 10:05
danielsimao
danielsimao reviewed Jul 22, 2022
View reviewed changes
src/App.tsx Outdated Show resolved Hide resolved
@crypto-engineer crypto-engineer force-pushed the refactor/governance-token-balance branch from 098a3aa to e3be5b8 Compare July 25, 2022 18:54
tomjeatt
tomjeatt requested changes Jul 26, 2022
View reviewed changes
src/pages/Staking/index.tsx Outdated Show resolved Hide resolved
src/pages/Staking/index.tsx Outdated Show resolved Hide resolved
tomjeatt
tomjeatt approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Anton

danielsimao
danielsimao requested changes Jul 27, 2022
View reviewed changes
src/pages/Bridge/IssueForm/index.tsx Outdated Show resolved Hide resolved
@crypto-engineer crypto-engineer merged commit f89bec2 into interlay:master Jul 27, 2022
@crypto-engineer crypto-engineer deleted the refactor/governance-token-balance branch July 27, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

@danielsimao danielsimao danielsimao approved these changes

@peterslany peterslany Awaiting requested review from peterslany

Assignees

@crypto-engineer crypto-engineer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crypto-engineer @tomjeatt @danielsimao