Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Dl component #403

Merged
merged 3 commits into from
Jul 27, 2022
Merged

feature: Dl component #403

merged 3 commits into from
Jul 27, 2022

Conversation

tomjeatt
Copy link
Collaborator

@tomjeatt tomjeatt commented Jul 26, 2022

Add a definition list component. This is a text component which is needed for the updated vault dashboard header. This is the only use case at the moment, so there are no variants but it can be extended as and when necessary.

Screenshot 2022-07-26 at 11 59 52

Screenshot 2022-07-26 at 12 00 09

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 11:35AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 11:35AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 11:35AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 11:35AM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

@tomjeatt
Copy link
Collaborator Author

@danielsimao this is in draft (hasn't been reviewed with Jay), but could you take a look at the typing and let me know if any changes are needed to make it consistent with the changes we've introduced in the other componenets?

Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomjeatt tomjeatt merged commit c750a1e into master Jul 27, 2022
@tomjeatt tomjeatt deleted the tom/definition-list branch July 27, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants