Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rui/tabs #407

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Rui/tabs #407

merged 6 commits into from
Jul 29, 2022

Conversation

danielsimao
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jul 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 29, 2022 at 8:34AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 29, 2022 at 8:34AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 29, 2022 at 8:34AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 29, 2022 at 8:34AM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

danielsimao
danielsimao commented Jul 27, 2022
View reviewed changes
src/component-library/Tabs/Tab.tsx Show resolved Hide resolved
src/component-library/Tabs/Tabs.style.tsx Outdated Show resolved Hide resolved
src/component-library/Tabs/Tabs.tsx Outdated Show resolved Hide resolved
src/component-library/Tabs/Tabs.tsx Show resolved Hide resolved
src/component-library/theme/theme.base.css Show resolved Hide resolved
src/component-library/theme/theme.kintsugi.css Show resolved Hide resolved
@danielsimao
Copy link
Member Author

Move transitions out of component

tomjeatt
tomjeatt approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - couple of changes, but I don't need to look again so once those changes have been made you can merge it in.

@danielsimao
Copy link
Member Author

Missing interlay colors

crypto-engineer
crypto-engineer approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsimao danielsimao merged commit c163516 into master Jul 29, 2022
@danielsimao danielsimao deleted the rui/tabs branch July 29, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

@crypto-engineer crypto-engineer crypto-engineer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielsimao @tomjeatt @crypto-engineer