Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rui/score bar #410

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Rui/score bar #410

merged 5 commits into from
Aug 4, 2022

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Jul 29, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Jul 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 11:45AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 11:45AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 11:45AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 11:45AM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

@danielsimao
Copy link
Member Author

Needs more discuss regarding severity ranges CC:@peterslany

crypto-engineer
crypto-engineer approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsimao
Copy link
Member Author

https://www.loom.com/share/fbbe0f2cea764a8a9fe7760b205a04d4

This is the latest approach

peterslany
peterslany approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I appreciate how you managed to solve the issue with the ranges very well 👍 I brought up some minor comments that are not blocking merging :)

src/component-library/utils/prop-types.ts Outdated Show resolved Hide resolved
src/component-library/CollateralScore/CollateralScore.tsx Outdated Show resolved Hide resolved
src/component-library/CollateralScore/CollateralScore.style.tsx Outdated Show resolved Hide resolved
src/component-library/CollateralScore/CollateralScore.tsx Outdated Show resolved Hide resolved
src/component-library/theme/theme.base.css Show resolved Hide resolved
@danielsimao danielsimao removed the request for review from tomjeatt August 4, 2022 11:23
@danielsimao danielsimao merged commit a4c5424 into master Aug 4, 2022
@danielsimao danielsimao deleted the rui/score-bar branch August 4, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt left review comments

@peterslany peterslany peterslany approved these changes

@crypto-engineer crypto-engineer crypto-engineer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielsimao @tomjeatt @peterslany @crypto-engineer