Tom/xcm text links #414
Merged
Tom/xcm text links #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
danielsimao
approved these changes
Aug 3, 2022
|
Some minor changes that I dont want to block the PR. Looks good to me overall. |
danielsimao
approved these changes
Aug 3, 2022
|
Ship it 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a variant to the warning banner, tweaks the component to allow non-text content (i.e. links), and adds an instance of the banner to Interlay linking to Acala/Moonbeam. Note: default link colours don't work for Kintsugi (yellow on yellow) but this is out of scope as the banner isn't displayed on Kintsugi, and this component will be deprecated in favour of the updated notifications that are currently in progress.