Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/currency updates #417

Merged
merged 6 commits into from
Aug 18, 2022
Merged

Refactor/currency updates #417

merged 6 commits into from
Aug 18, 2022

Conversation

crypto-engineer
Copy link
Contributor

@crypto-engineer crypto-engineer commented Aug 3, 2022 •
edited
Loading

Make the necessary changes for the changes made to the lib regarding the currencies.

@vercel
Copy link

vercel bot commented Aug 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 7:23AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 7:23AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 7:23AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 7:23AM (UTC)

@crypto-engineer crypto-engineer marked this pull request as draft August 3, 2022 23:55
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Running Lighthouse audit...

@crypto-engineer crypto-engineer self-assigned this Aug 4, 2022
@crypto-engineer crypto-engineer added the enhancement New feature or request label Aug 4, 2022
crypto-engineer
crypto-engineer commented Aug 17, 2022
View reviewed changes
src/App.tsx Outdated Show resolved Hide resolved
@crypto-engineer crypto-engineer marked this pull request as ready for review August 17, 2022 08:05
peterslany
peterslany reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this large change! :) I left some comments - some of those need to be handled.

src/App.tsx Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/Tokens/index.tsx Show resolved Hide resolved
src/components/Vaults/index.tsx Show resolved Hide resolved
src/pages/Bridge/BurnForm/index.tsx Show resolved Hide resolved
src/pages/Bridge/IssueForm/index.tsx Show resolved Hide resolved
src/pages/Dashboard/sub-pages/Vaults/VaultsTable/index.tsx Show resolved Hide resolved
@crypto-engineer
Copy link
Contributor Author

0

peterslany
peterslany approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be merged and then we can handle raised issues separately 👍

@crypto-engineer crypto-engineer merged commit 8815ee6 into interlay:master Aug 18, 2022
@crypto-engineer crypto-engineer deleted the refactor/currency-updates branch August 18, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvotteler bvotteler bvotteler left review comments

@peterslany peterslany peterslany approved these changes

@tomjeatt tomjeatt Awaiting requested review from tomjeatt

@danielsimao danielsimao Awaiting requested review from danielsimao

Assignees

@crypto-engineer crypto-engineer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crypto-engineer @bvotteler @peterslany