-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get thresholds for supported collaterals only #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Running Lighthouse audit... |
danielsimao
approved these changes
Aug 9, 2022
crypto-engineer
added a commit
to crypto-engineer/interbtc-ui
that referenced
this pull request
Aug 9, 2022
crypto-engineer
added a commit
to crypto-engineer/interbtc-ui
that referenced
this pull request
Aug 12, 2022
crypto-engineer
added a commit
to crypto-engineer/interbtc-ui
that referenced
this pull request
Aug 16, 2022
…es for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault feat: upgrade @interlay/interbtc-api, mark change points, and fix cases for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault fix: correct PR interlay#431 changes chore: mark the issue points (WIP) fix: update VaultsTable chore: add testing cases fix: correct USE_WRAPPED_CURRENCY_LINK chore: clean up docs: add a TODO comment
crypto-engineer
added a commit
to crypto-engineer/interbtc-ui
that referenced
this pull request
Aug 16, 2022
…es for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault feat: upgrade @interlay/interbtc-api, mark change points, and fix cases for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault fix: correct PR interlay#431 changes chore: mark the issue points (WIP) fix: update VaultsTable chore: add testing cases fix: correct USE_WRAPPED_CURRENCY_LINK chore: clean up docs: add a TODO comment
crypto-engineer
added a commit
to crypto-engineer/interbtc-ui
that referenced
this pull request
Aug 16, 2022
…es for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault feat: upgrade @interlay/interbtc-api, mark change points, and fix cases for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault fix: correct PR interlay#431 changes chore: mark the issue points (WIP) fix: update VaultsTable chore: add testing cases fix: correct USE_WRAPPED_CURRENCY_LINK chore: clean up docs: add a TODO comment fix: replace issue.getVaultIssuableAmount with vaults.getIssuableTokensFromVault fix: update VaultsTable
crypto-engineer
added a commit
to crypto-engineer/interbtc-ui
that referenced
this pull request
Aug 16, 2022
…es for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault feat: upgrade @interlay/interbtc-api, mark change points, and fix cases for new BitcoinAmount() and BitcoinAmount.zero() refactor: update ChainBalance cases refactor: update MonetaryAmount<CollateralCurrencyExt> cases chore: clean up refactor: update ReplaceTable refactor: update MonetaryAmount<CurrencyExt> cases chore: clean up refactor: update CURRENCIES refactor: update for RELAY_CHAIN_NATIVE_TOKEN and CollateralToken chore: clean up refactor: update with RELAY_CHAIN_NATIVE_TOKEN_ID_LITERAL chore: clean up refactor: update with WRAPPED_TOKEN chore: clean up refactor: update with WrappedTokenIdLiteral and GovernanceTokenIdLiteral chore: clean up refactor: remove GOVERNANCE_TOKEN_ID_LITERAL use cases refactor: remove CollateralCurrency use cases chore: clean up chore: add TODOs temporarily refactor: update getUsdAmount refactor: update relay-chains chore: clean up refactor: update oracle-exchange-rates-fetcher chore: clean up refactor: update currency.ts refactor: update with GovernanceCurrency chore: clean up refactor: update VaultExt cases chore: clean up refactor: update CurrencyUnit cases chore: clean up fix: correct InterbtcPrimitivesReplaceReplaceRequestStatus usage refactor: update rawBase cases chore: clean up refactor: update str.BTC cases chore: clean up refactor: update getCurrency use cases chore: clean up refactor: update Vault issues refactor: update some cases refactor: update VAULT_COLLATERAL_TOKENS use cases fix: update some cases refactor: update CURRENCIES refactor: update some cases chore: clean up fix: suppress one type error chore: format refactor: update genericFetcher cases feat: upgrade @interlay/interbtc-api chore: clean up fix: correct types chore: clean up fix: correct commenting chore: clean up chore: clean up refactor: update Vault fix: correct PR interlay#431 changes chore: mark the issue points (WIP) fix: update VaultsTable chore: add testing cases fix: correct USE_WRAPPED_CURRENCY_LINK chore: clean up docs: add a TODO comment fix: replace issue.getVaultIssuableAmount with vaults.getIssuableTokensFromVault fix: update VaultsTable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to get threshold limits only for supported collateral threshold currencies in the VaultTable.