Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): styles and accessibility #447

Merged
merged 1 commit into from
Aug 12, 2022
Merged

fix(Modal): styles and accessibility #447

merged 1 commit into from
Aug 12, 2022

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Aug 12, 2022 •
edited
Loading

  • close button miss aria-label and small size (hard to click on mobile)
  • modal content wrapper role missing
  • standardise modal padding according to Jay designs
  • add missing overlay

In the future we need to improve styles and maybe implement react-aria and react-stately because there are some missing features

@vercel
Copy link

vercel bot commented Aug 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 0:27AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 0:27AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 0:27AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 0:27AM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

peterslany
peterslany approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@peterslany
Copy link
Contributor

In the future we need to improve styles and maybe implement react-aria and react-stately because there are some missing features

I agree, if we start needing these features, we can extend it in the future 👍

@danielsimao danielsimao merged commit d29a44c into master Aug 12, 2022
@danielsimao danielsimao deleted the rui/modal-improvements branch August 12, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterslany peterslany peterslany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielsimao @peterslany