fix: show APR instead of APY #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
danielsimao
approved these changes
Aug 12, 2022
peterslany
suggested changes
Aug 12, 2022
| @@ -46,7 +46,7 @@ | |||
| "update": "Update", | |||
| "collateralization": "Collateralization", | |||
| "fees_earned": "Fees earned", | |||
| "apy": "APY", | |||
| "apy": "APR", | |||
There was a problem hiding this comment.
I think we should change the locale text key to "apr" to keep the codebase clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill [email protected]
Quick replace of only the places where we display "APY", still need to change variable names etc..