-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/locale formatting #459
Merged
crypto-engineer
merged 6 commits into
interlay:master
from
crypto-engineer:feature/locale-formatting
Aug 19, 2022
Merged
Feature/locale formatting #459
crypto-engineer
merged 6 commits into
interlay:master
from
crypto-engineer:feature/locale-formatting
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crypto-engineer
requested review from
peterslany and
tomjeatt
and removed request for
peterslany
August 18, 2022 07:50
Running Lighthouse audit... |
tomjeatt
reviewed
Aug 18, 2022
tomjeatt
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, so can be merged when you've pushed the update to change where the formatting happens :)
crypto-engineer
force-pushed
the
feature/locale-formatting
branch
from
August 19, 2022 08:03
1c147ca
to
52ca8f3
Compare
refactor: update VaultOverview with formatUSD chore: clean up refactor: update with formatUSD chore: clean up
crypto-engineer
force-pushed
the
feature/locale-formatting
branch
from
August 19, 2022 08:04
52ca8f3
to
7da27b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format USD amount cases which were missed in the previous PR.