Feature/number formatting #466

crypto-engineer · 2022-08-22T09:59:30Z

Added utilities:

formatNumber
formatPercentage (0.1 -> 10%)

vercel · 2022-08-22T09:59:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
interbtc-ui-interlay	✅ Ready (Inspect)	Visit Preview	Aug 24, 2022 at 8:25AM (UTC)
interbtc-ui-interlay-testnet	✅ Ready (Inspect)	Visit Preview	Aug 24, 2022 at 8:25AM (UTC)
interbtc-ui-kintsugi	✅ Ready (Inspect)	Visit Preview	Aug 24, 2022 at 8:25AM (UTC)
interbtc-ui-kintsugi-testnet	✅ Ready (Inspect)	Visit Preview	Aug 24, 2022 at 8:25AM (UTC)

github-actions · 2022-08-22T09:59:52Z

Running Lighthouse audit...

crypto-engineer · 2022-08-22T10:01:46Z

~~Test displayMonetaryAmount cases (regression test)~~
~~issue_page.confirmations~~
~~toHuman -> returning number~~
~~displayMonetaryAmountInUSDFormat~~
~~safeRoundTwoDecimals cases~~
%

src/components/Vaults/VaultsSelector/index.tsx

src/pages/Dashboard/sub-pages/Oracles/OraclesTable/index.tsx

src/common/utils/utils.ts

tomjeatt

Looks good :) one comment, not a blocker

src/component-library/VaultCard/VaultCard.tsx

feat: update number formatting cases feat: update number formatting cases chore: mark an edge case chore: mark an edge case feat: update number formatting cases feat: update number formatting cases feat: update number formatting cases fix: correct getCollateralization feat: update number formatting cases chore: clean up chore: clean up fix: update Vault chore: clean up

crypto-engineer marked this pull request as draft August 22, 2022 09:59

crypto-engineer self-assigned this Aug 22, 2022

crypto-engineer added bug Something isn't working enhancement New feature or request labels Aug 22, 2022

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 22, 2022 10:02 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 22, 2022 10:03 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 22, 2022 10:05 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 22, 2022 10:08 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 23, 2022 02:31 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 23, 2022 02:32 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 23, 2022 02:32 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 23, 2022 02:35 View deployment

crypto-engineer commented Aug 23, 2022

View reviewed changes

src/components/Vaults/VaultsSelector/index.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – interbtc-ui-kintsugi August 23, 2022 02:52 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 23, 2022 02:52 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 23, 2022 02:53 View deployment

crypto-engineer force-pushed the feature/number-formatting branch from 2de3c39 to 472bee6 Compare August 23, 2022 02:54

crypto-engineer commented Aug 23, 2022

View reviewed changes

src/pages/Dashboard/sub-pages/Oracles/OraclesTable/index.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 23, 2022 02:59 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 23, 2022 02:59 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 23, 2022 03:02 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 23, 2022 03:02 View deployment

crypto-engineer commented Aug 23, 2022

View reviewed changes

src/common/utils/utils.ts Show resolved Hide resolved

vercel bot deployed to Preview – interbtc-ui-interlay August 23, 2022 03:16 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 23, 2022 03:16 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 23, 2022 03:16 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 23, 2022 03:20 View deployment

crypto-engineer marked this pull request as ready for review August 24, 2022 04:55

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 24, 2022 04:57 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 24, 2022 04:57 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 24, 2022 04:57 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 24, 2022 05:00 View deployment

crypto-engineer force-pushed the feature/number-formatting branch from b0b18b4 to a764513 Compare August 24, 2022 06:29

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 24, 2022 06:32 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 24, 2022 06:32 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 24, 2022 06:32 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 24, 2022 06:35 View deployment

crypto-engineer force-pushed the feature/number-formatting branch from a764513 to 370c889 Compare August 24, 2022 06:39

vercel bot deployed to Preview – interbtc-ui-interlay August 24, 2022 06:45 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 24, 2022 06:45 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 24, 2022 06:46 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 24, 2022 06:50 View deployment

tomjeatt approved these changes Aug 24, 2022

View reviewed changes

src/component-library/VaultCard/VaultCard.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 24, 2022 07:36 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi August 24, 2022 07:36 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 24, 2022 07:37 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 24, 2022 07:39 View deployment

crypto-engineer added 3 commits August 24, 2022 11:10

fix: update VaultCard

6e46d95

chore: clean up

06fb710

crypto-engineer force-pushed the feature/number-formatting branch from 8448f62 to 06fb710 Compare August 24, 2022 08:11

vercel bot deployed to Preview – interbtc-ui-kintsugi August 24, 2022 08:24 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay-testnet August 24, 2022 08:25 View deployment

vercel bot deployed to Preview – interbtc-ui-kintsugi-testnet August 24, 2022 08:25 View deployment

vercel bot deployed to Preview – interbtc-ui-interlay August 24, 2022 08:25 View deployment

crypto-engineer merged commit d494657 into interlay:master Aug 24, 2022

crypto-engineer deleted the feature/number-formatting branch August 24, 2022 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/number formatting #466

Feature/number formatting #466

crypto-engineer commented Aug 22, 2022 •

edited

Loading

vercel bot commented Aug 22, 2022 •

edited

Loading

github-actions bot commented Aug 22, 2022

crypto-engineer commented Aug 22, 2022 •

edited

Loading

tomjeatt left a comment

Feature/number formatting #466

Feature/number formatting #466

Conversation

crypto-engineer commented Aug 22, 2022 • edited Loading

vercel bot commented Aug 22, 2022 • edited Loading

github-actions bot commented Aug 22, 2022

crypto-engineer commented Aug 22, 2022 • edited Loading

tomjeatt left a comment

Choose a reason for hiding this comment

crypto-engineer commented Aug 22, 2022 •

edited

Loading

vercel bot commented Aug 22, 2022 •

edited

Loading

crypto-engineer commented Aug 22, 2022 •

edited

Loading