Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rui/input label helper text #484

Merged
merged 9 commits into from
Sep 15, 2022
Merged

Rui/input label helper text #484

merged 9 commits into from
Sep 15, 2022

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Sep 7, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Sep 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 10:58AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 10:58AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 10:58AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 10:58AM (UTC)

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Running Lighthouse audit...

tomjeatt
tomjeatt reviewed Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice solution/refactoring. Few comments, nothing major.

src/component-library/HelperText/HelperText.tsx Outdated Show resolved Hide resolved
src/component-library/HelperText/HelperText.tsx Show resolved Hide resolved
src/component-library/Input/BaseInput.tsx Show resolved Hide resolved
src/component-library/Input/BaseInput.tsx Outdated Show resolved Hide resolved
src/component-library/Input/BaseInput.tsx Show resolved Hide resolved
src/component-library/Input/Input.style.tsx Outdated Show resolved Hide resolved
src/component-library/Input/Input.style.tsx Outdated Show resolved Hide resolved
tomjeatt
tomjeatt approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) thanks for the changes

@danielsimao danielsimao merged commit 9b7f19e into master Sep 15, 2022
@danielsimao danielsimao deleted the rui/input-label-helper-text branch September 15, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielsimao @tomjeatt