Vault dashboard issue requests modal #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
tomjeatt
commented
Sep 12, 2022
src/pages/Vaults/Vault/components/TransactionHistory/TransactionTable.tsx
Show resolved
Hide resolved
tomjeatt
changed the title
danielsimao
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the modals from the transactions table to show issue and redeem request details. This is a quick fix to get the release out; we'll review the use of the modal, and if we decide to continue with it (rather than replace it) then we will need to refactor it, and move the modal components to a shared directory.
For now though, this is an acceptable solution - we'll be reviewing the dashboard and overview implementation soon, and we can review the modal at the same time.