Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CTA): add loading and refactor #492

Merged
merged 3 commits into from
Sep 15, 2022
Merged

feat(CTA): add loading and refactor #492

merged 3 commits into from
Sep 15, 2022

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Sep 12, 2022 •
edited
Loading

  • added loading spinner and color contrast for each spinner
  • added BaseCTA because we don't want business logic for loading in CTALink.

@vercel
Copy link

vercel bot commented Sep 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 4:18PM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 4:18PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 4:18PM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 4:18PM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

peterslany
peterslany reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! I found a minor bug there that needs to be fixed, but otherwise it looks good :)

src/component-library/CTA/CTA.tsx Outdated Show resolved Hide resolved
tomjeatt
tomjeatt reviewed Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice refactor. Couple of minor comments.

src/component-library/CTA/BaseCTA.tsx Show resolved Hide resolved
src/component-library/CTA/CTA.tsx Show resolved Hide resolved
@tomjeatt tomjeatt self-requested a review September 15, 2022 15:42
tomjeatt
tomjeatt approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielsimao danielsimao merged commit c147e4a into master Sep 15, 2022
@danielsimao danielsimao deleted the rui/cta-loading-and-link branch September 15, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

@peterslany peterslany Awaiting requested review from peterslany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielsimao @tomjeatt @peterslany