Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.3.2: Wrong translation of Vision datapoint xxx.mower.partyModus to cfg.sc.enabled #761

Closed
hsteinme opened this issue Sep 21, 2023 · 3 comments
Closed

Version 2.3.2: Wrong translation of Vision datapoint xxx.mower.partyModus to cfg.sc.enabled #761

hsteinme opened this issue Sep 21, 2023 · 3 comments
Assignees
@Lucky-ESA
Labels
bug Something isn't working

Comments

@hsteinme
Copy link

hsteinme commented Sep 21, 2023 •
edited
Loading

The Vision datapoint xxx.mower.partyModus does not have a correct effect on the mower. Reason: partyModus = true is incorrectly translated to cfg.sc.enabled = 1 instead of cfg.sc.enabled = 0.

 sendPartyModus(id, value, mower) {
        if (mower.capabilities != null && mower.capabilities.includes("vision")) {
            const val = value ? 1 : 0;
            this.sendMessage(`{"sc":{ "enabled":${val}}}`, mower.serial_number, id);
        } ...

Problem was originally reported in the roboter forum,
@Lucky-ESA Lucky-ESA added the bug Something isn't working label Sep 24, 2023
@Lucky-ESA Lucky-ESA self-assigned this Sep 24, 2023
@Lucky-ESA
Copy link
Collaborator

@hsteinme
Thanks for this info. Is fixed with next release.
BR//Lucly

Lucky-ESA added a commit that referenced this issue Sep 24, 2023
@Lucky-ESA
Fixed [#761]
4b918b7
@EngelenJ
Copy link

Nice, thank you!

Lucky-ESA added a commit that referenced this issue Sep 25, 2023
@Lucky-ESA
chore: release v2.3.3
af2bc12 
-   (Lucky-ESA) Added cmd wifi lock for Vision
-   (Lucky-ESA) Fixed [#761](#761)
-   (Lucky-ESA) Added sequence for Vision
-   (Lucky-ESA) Checking working hours and locktime
-   (Lucky-ESA) Fixed incorrect log message for firmware update
@Lucky-ESA
Copy link
Collaborator

Fixed in release 2.3.3 latest or stable >= 2.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lucky-ESA Lucky-ESA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hsteinme @Lucky-ESA @EngelenJ