Upgrade Fable #1415
Merged
Upgrade Fable #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dotnet tools
Note: The files from `ionide-vscode-helper` are currently from local folder `../ionide-vscode-helper` (`fable-upgrade` branch).
Useful for development (vs production): dev output (release/fsharp.fs) isn't minimized.
Fable now throws an exception when `dict.Add(key,value)` for an already existing value. Previously that worked.
Error was: Project files (and References and Items (`DTO.fs` -> `Project`)) are stored as `list` in F# -- but during runtime (in JS) it's actually an `array`. In older Fable versions `List` functions worked with arrays. But now calling a `List` function on an array returns an empty list. ```fsharp // ls: (more than 0 values) // * in F#: 'a list // * in JS: 'a array ls |> List.iter (printfn "%A") ``` Previously: Prints each item Now: Doesn't print anything Note: Being an `array` is already the case in current ionide version `4.16.0` and wasn't introduced by upgrading Fable. This might indicate a mistake during (de)serialization, but I didn't look into it. Instead `list` is just changed to `array`.
`Fable.HtmlConverter` `2.0.0` doesn't work with current fable -> for dev: include fixed source from local folder `../html-to-elmish/`
Note: both are not served from the original repositories, but forked repos with updated files. Will be reverted after the source repos were updated.
This was referenced Sep 13, 2020
Add framework restriction Disable packages folder
|
Can you target And wow, thanks a lot for those changes. Updating Fable is something we've put off for way too long |
|
|
|
Some of the refactoring done (e.g., aliasing |
|
Well, this is awesome, thanks a lot ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036 (though a couple of versions higher)
There are a couple of changes in the current fable version compared to the one used in current ionide -- and some are quite subtle. For example passed functions that previously were called now don't (ionide/ionide-vscode-helpers@ada99c8) or stricter handling for different types in F# (in code) and JS (during runtime) (92ecbd0).
I'm not sure I caught all those strange cases. The ones I found had strong impact -- like no files in Solution Explorer. But there might be other cases not so visible. And I didn't test it with a bigger project and over a longer period of time.
-> others should probably test it a bit more with their workflow
Requires
ionide/ionide-vscode-helpers#33andMangelMaxime/html-to-elmish#22(-> reason this PR is marked as WIP)For now the files for both are included from the PRs branches. So this should build just fine for testing.
I will change it back once the PRs are merged (and updated nuget package is released in case of
html-to-elmish/Fable.HtmlConverter).