Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: prioritize roots and introduce NewPrioritizedProvider #595

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 26, 2024

@hacdias hacdias self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 59.77%. Comparing base (5fc25a4) to head (096cc05).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   59.78%   59.77%   -0.01%     
==========================================
  Files         232      232              
  Lines       28139    28186      +47     
==========================================
+ Hits        16822    16848      +26     
- Misses       9840     9862      +22     
+ Partials     1477     1476       -1     
Files Coverage Δ
provider/provider.go 25.74% <40.00%> (+25.74%) ⬆️

... and 10 files with indirect coverage changes

@hacdias
Copy link
Member Author

hacdias commented Mar 26, 2024

@aschmahmann what do you think? I can replace the map with a bloom filter. That can probably be better memory wise depending on how streams we're using.

@hacdias hacdias marked this pull request as ready for review March 26, 2024 13:36
@hacdias hacdias requested a review from a team as a code owner March 26, 2024 13:36
provider/provider.go Outdated Show resolved Hide resolved
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can ship this if we limit CID map to items from the first-pass (details inline).

provider/provider.go Outdated Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
@hacdias hacdias requested a review from lidel April 4, 2024 11:06
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took it for a spin in ipfs/kubo#10376 and seem to work as expected.

provider/provider.go Outdated Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (squash) April 9, 2024 06:10
@hacdias hacdias changed the title provider: introduce NewPrioritizedProvider provider: prioritize roots and introduce NewPrioritizedProvider Apr 9, 2024
@hacdias hacdias merged commit ec20793 into main Apr 9, 2024
14 checks passed
@hacdias hacdias deleted the prioritized-provider branch April 9, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants