core/corehttp!: remove /api/v0 from gateway port #10352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
changed the title
2 tasks
hacdias
changed the title
hacdias
changed the title
hacdias
force-pushed
the
remove-api-on-gateway
branch
from
d822a07
to
74258c0
Compare
hacdias
force-pushed
the
remove-api-on-gateway
branch
2 times, most recently
from
f2bf366
to
3e20448
Compare
lidel
approved these changes
Mar 4, 2024
Comment on lines
+15
to
+24
| #### Gateway: `/api/v0` is removed | ||
|
|
||
| The legacy subset of the Kubo RPC that was available via the Gateway port and was deprecated is now completely removed. You can read more in <https://github.com/ipfs/kubo/issues/10312>. | ||
|
|
||
| If you have a legacy software that relies on this behavior, and want to expose parts of `/api/v0` next to `/ipfs`, use reverse-proxy in front of Kubo to mount both Gateway and RPC on the same port. NOTE: exposing RPC to the internet comes with security risk: make sure to specify access control via [API.Authorizations](https://github.com/ipfs/kubo/blob/master/docs/config.md#apiauthorizations). |
| @@ -50,7 +50,7 @@ test_expect_success "docker image runs" ' | |||
| ' | |||
|
|
|||
| test_expect_success "docker container gateway is up" ' | |||
| pollEndpoint -host=/ip4/127.0.0.1/tcp/8080 -http-url http://localhost:8080/api/v0/version -v -tries 30 -tout 1s | |||
There was a problem hiding this comment.
💭 I suspect /api/v0/version is used as healthcheck by various monitoring tools.
Mind updating waterworks-infra in preparation for this removal?
/api/v0/version seems to be used in a few places, including pingdom:
https://github.com/search?q=repo%3Aipshipyard%2Fwaterworks-infra+api%2Fv0%2Fversion&type=code
Maybe @ns4plabs knows other places.
There was a problem hiding this comment.
| "/object/links", | ||
| "/object/stat", | ||
| "/refs", | ||
| "/resolve", |
There was a problem hiding this comment.
💭 if someone needs replacement for /api/v0/resolve we could tell them to use x-ipfs-roots:
$ curl https://ipfs.io/ipns/en.wikipedia-on-ipfs.org/favicon.ico -X HEAD -is | grep -i ipfs-roots
x-ipfs-roots: bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze,bafkreicl5473u3g5c2l34n5oh5trtpft56ep6mbqv57affzgkfppcitfl4
hacdias
force-pushed
the
remove-api-on-gateway
branch
from
3e20448
to
6dc20dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
/api/v0from the gateway port. Closes #10312.We can merge this before the final 0.27 release. I will have to cherry-pick anyways.