core/commands!: remove deprecated object APIs #10375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
remove-object
branch
2 times, most recently
from
a3c68bf
to
c552d08
Compare
hacdias
commented
Mar 19, 2024
lidel
requested changes
Mar 20, 2024
lidel
force-pushed
the
remove-object
branch
2 times, most recently
from
141bdd3
to
6529303
Compare
This allows us to return meaningful error to end users who were not aware of deprecation, and also produce useful removal notice at https://docs.ipfs.tech/reference/kubo/rpc/ for people who try to execute commands or RPC from old tutorials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to remove all deprecated Object API commands (deprecated since 2021, #7936), except for
object diff, which does not have an alternative.Closes #8887
Closes #3359
Closes #7384
Closes #5058
Closes #1724