-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the tests #844
fix the tests #844
Conversation
Looks like fuse broke sometime in the last week.
Bisecting, it looks like it was introduced in: c88340b |
|
@whyrusleeping thanks for ptr. merged #838 |
The recent failures in:
perhaps indicate that the dreadful |
If anyone can get that problem (the dreadful Possible that changing the daemon to load the http servers before bootstrapping will make the problem go away. (though the weird thing is this hang happens after bootrstrap, after at least either the http gateway or API line has printed...) |
@whyrusleeping's fix in c88340b broke reading fuse in osx. i'm not sure why... anyway, i chose to revert back to io.ReadFull, but use the min of req.Size and r.Size(), which should not encounter the reading problem in linux that a77ea2f fixed in the first place. This commit also changes ipns, which had not been changed.
we have a problem where initializing daemons with the same api port often fails-- it hangs indefinitely. The proper solution is to make ipfs pick an unused port for the api on startup, and then use that. Unfortunately, ipfs doesnt yet know how to do this-- the api port must be specified. Until ipfs learns how to do this, we must use specific port numbers, which may still fail but less frequently if we at least use different ones.
ideally this port would be a randomly picked unused port. for now we just pick a different port than t0110-gateway.
this is ugly. ideally would seed using date, but unclear what a portable datetime is. date '+%s' doesnt work on osx.
closes #836
thanks @cryptix -- for fixing the worst |
this PR will get our tests back to green