Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmds): add dag diff #8711

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Feb 2, 2022

IPFS_CMD=cmd/ipfs/ipfs
NODE_BEFORE=QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn # empty dir
NODE_AFTER=QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc # ipfs init dir
$IPFS_CMD dag diff $NODE_BEFORE $NODE_AFTER
[
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmQy6xmJhrcC5QLboAcGFcAE1tC8CrwDVkrHdEYJkLscrQ"
      },
      "Name": "about",
      "Tsize": 1692
    }
  },
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmYCvbfNbCwFR45HiNP45rwJgvatpiW38D961L5qAhUM5Y"
      },
      "Name": "contact",
      "Tsize": 200
    }
  },
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmU5k7ter3RdjZXu3sHghsga1UQtrztnQxmTL22nPnsu3g"
      },
      "Name": "help",
      "Tsize": 322
    }
  },
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmejvEPop4D7YUadeGqYWmZxHhLc4JBUCzJJHWMzdcMe2y"
      },
      "Name": "ping",
      "Tsize": 12
    }
  },
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmQGiYLVAdSHJQKYFRTJZMG4BXBHqKperaZtyKGmCRLmsF"
      },
      "Name": "quick-start",
      "Tsize": 1692
    }
  },
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB"
      },
      "Name": "readme",
      "Tsize": 1102
    }
  },
  {
    "op": "add",
    "path": "/Links/-",
    "value": {
      "Hash": {
        "/": "QmQ5vhrL7uv6tuoN9KeVBwd4PwfQkXdVVmDLUZuTNxqgvm"
      },
      "Name": "security-notes",
      "Tsize": 1173
    }
  }
]

Toward #4801.

@schomatis schomatis requested a review from lidel February 2, 2022 15:40
@schomatis schomatis self-assigned this Feb 2, 2022
@schomatis schomatis mentioned this pull request Feb 2, 2022
go.mod Outdated Show resolved Hide resolved
@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
@BigLep BigLep linked an issue Mar 11, 2022 that may be closed by this pull request
go.mod Outdated Show resolved Hide resolved
core/commands/dag/dag.go Show resolved Hide resolved
core/commands/dag/diff.go Outdated Show resolved Hide resolved
@schomatis schomatis force-pushed the schomatis/feat/cmds/dag-diff branch from d58bad1 to f395582 Compare April 28, 2022 16:11
@schomatis schomatis marked this pull request as ready for review April 28, 2022 16:12
@schomatis schomatis force-pushed the schomatis/feat/cmds/dag-diff branch from f395582 to 1110864 Compare April 28, 2022 16:15
@schomatis
Copy link
Contributor Author

@lidel Thanks for the pointers. Ready for another round of review.

@schomatis schomatis requested a review from lidel April 28, 2022 16:16
@schomatis schomatis force-pushed the schomatis/feat/cmds/dag-diff branch from 1110864 to cdefb64 Compare April 28, 2022 16:21
@BigLep BigLep modified the milestones: kubo 0.14, kubo 0.15 Jul 22, 2022
@BigLep
Copy link
Contributor

BigLep commented Oct 4, 2022

2022-10-04 Kubo standup conversation: this requires deeper thought because it has impact on other commands. When we pick this up, it will be good to engage with it during the IPLD community call.

@BigLep BigLep marked this pull request as draft November 17, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🥞 Todo
Development

Successfully merging this pull request may close these issues.

ipfs dag diff
3 participants