-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsass is now deprecated... move to dartsass #47
Comments
I’m pretty sure that the dart sass library can be compiled to a native library as well. I will have a look at it. |
Any progress on this? It would be great to be able to use |
I'll try to see what the impact would be of migrating from libsass to a version of dart-sass compiled to libsass. Unfortunately, that would require having node on the target system. I haven't yet found a way to compile dart code to a shared library. |
@irundaia sure I can help you test it out on my M1 Mac! |
@irundaia Yeah, I can help test (Intel macOS). I'm currently using dart-sass from IntelliJ's file watchers, so I'd be glad to get away from that. |
+1, I can test on Ubuntu / Fedora environments. Would love to use sassify and dartsass. |
@irundaia Dart Sass releases its binaries on github https://github.com/sass/dart-sass/releases/tag/1.49.0. Changing the bundled binaries inside the published jar should solve the problem. |
Nevermind, I thought you were invoking the cli. Now looking deeper I see your are using JNA to invoke the native methods from libsass, so moving to dart-sass will probably be harder since the native methods will be diferent. |
@rwsargent, @Lasering, @danellis, @bpossolo, I've refactored sbt-sassify to include a version of dart-sass. Could you verify if this works with your setup. To test the integration with dart-sass, take the following steps:
Could you let me know whether this works for your setup? |
I might be doing something wrong. But for me it seems to not be working. The generated .css contains |
Do you have a minimal example? Can you set the |
That was the missing part. Now it works. |
I'm looking into this, running into an Akka mixed dependency error which I can't seem to resolve. |
@rwsargent could you provide a minimal example of your setup that exhibits this behaviour? |
@irundaia we've been able to successfully using your outlined steps here, which happens to also fix a docker aarch64 libsass.so issue we were facing with the 1.x build of sbt-sassify. Are you able to publish version 2.0.0? Even the snapshot build would be great as we're having difficulty including the local snapshot version as a plugin dependency via project/lib directory. Edit: My colleguea informed me he had to make the following change to get the build working on macOS aarch64
|
@irundaia When I set |
@irundaia Any update on this, can the dart-sass branch be merged in and released? |
As of Oct 26, 2020, libsass is now deprecated :(
The official recommendation is to move to dart sass instead.
I'm not sure what this means for the sbt-sassify plugin but it seems like having the Dart Sass binary installed locally may become a pre-requisite in the future.
The text was updated successfully, but these errors were encountered: