Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review #12

Open
italopessoa opened this issue Aug 30, 2017 · 0 comments
Open

code review #12

italopessoa opened this issue Aug 30, 2017 · 0 comments
Assignees
@italopessoa
Labels
enhancement

Comments

@italopessoa
Copy link
Owner

No description provided.

@italopessoa italopessoa self-assigned this Aug 30, 2017
italopessoa added a commit that referenced this issue Aug 30, 2017
@italopessoa
code review #12 remove parameter default value
9a43445 
codacy warning: Use the overloading mechanism instead of the optional parameters.

the type Enum already has a default type.
italopessoa added a commit that referenced this issue Aug 30, 2017
@italopessoa
code review #12, add default value
ffea1e8
italopessoa added a commit that referenced this issue Aug 30, 2017
@italopessoa
code review #12 remove unused code
a00b3ab
italopessoa added a commit that referenced this issue Aug 30, 2017
@italopessoa
code review #12 remove unused code
5b8595e
italopessoa added a commit that referenced this issue Aug 30, 2017
@italopessoa
code review #12 remove unused code
7ff904d
italopessoa added a commit that referenced this issue Aug 30, 2017
@italopessoa
Merge branch 'dev-api', code review #12
0d16ad9
italopessoa added a commit that referenced this issue Sep 7, 2017
@italopessoa
#12 remove content property from CardPanel
1a7da73 
use props.children instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@italopessoa italopessoa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@italopessoa