Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump google-api-python-client version to the latest #56

Merged
merged 1 commit into from
Sep 15, 2020
Merged

bump google-api-python-client version to the latest #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
description="Google Drive API made easy. Maintained fork of PyDrive.",
long_description=open("README.rst").read(),
install_requires=[
"google-api-python-client >= 1.7.12",
"google-api-python-client >= 1.12.1",
"six >= 1.13.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this as well, don't see a better way. We might need to do the same in dvc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm ... I don't understand why is it needed, google-api-python-client already specifies the same dependency. Any ideas on this?

Copy link
Member Author

@skshetry skshetry Sep 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip does not have a resolver (yet), so it either installs top-level requirements specification (as done here) or does "first one wins" which installs six from different dependency and ignores the one specified in google-api-python-client (it does raise warning at the end).
pypa/pip#988 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk, thanks @skshetry!

"oauth2client >= 4.0.0",
"PyYAML >= 3.0",
"pyOpenSSL >= 19.1.0",
Expand Down