Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct packing/ unpacking Matrices modulo Q ( = 2^D ) #11

Merged
merged 1 commit into from
May 20, 2023

Conversation

itzmeanjan
Copy link
Owner

Correct logic of packing/ unpacking matrices to/ from byte arrays, following algorithm 3/ 4.

Note Previously I was interpreting elements of matrices modulo Q in little-endian byte order, though if we carefully go through algorithm 3/ 4, we'll see we should actually interpret bytes in big-endian order.

Run tests, by issuing

make

@itzmeanjan itzmeanjan marked this pull request as ready for review May 20, 2023 14:29
@itzmeanjan itzmeanjan merged commit 11bef1e into master May 20, 2023
@itzmeanjan itzmeanjan deleted the correct-packing branch May 20, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant