Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer std::span over raw pointer based interfaces #37

Merged
merged 18 commits into from
Oct 1, 2023
Merged

Prefer std::span over raw pointer based interfaces #37

merged 18 commits into from
Oct 1, 2023

Conversation

itzmeanjan
Copy link
Owner

@itzmeanjan itzmeanjan commented Sep 18, 2023 •
edited
Loading

  • Use statically defined std::span in KEM function interfaces, instead of using raw pointer/ length pairs
  • Update sha3 dependency to latest commit ( bring in changes introduced in PR Bring Performance back to Keccak Permutation sha3#21 )
  • Rewrite make recipes for ease of maintenance
  • Update benchmark results

@itzmeanjan
relocate examples to different directory
76f7f19 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
just maintain a single file for benchmarks of KEM routines
3dcf0c2 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
rewrite Make recipes for ease of maintaining
6c26599 
Collected inspiration from https://github.com/itzmeanjan/saber/blob/b0f5ac2891a4133db300a18b469a1c68a39b2caf/Makefile

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
ask clang-format to use Mozilla code style when formatting sources
1264364 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
remove some redundant const keywords
b018b51 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
move test-helper function to test suite translation unit
4342044 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
bump dependency sha3 to latest commit
6567f48 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor all pointer, length pair based APIs of Kyber PKE to use `std…
0ebc63d 
…::span` instead

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor API surface of Kyber KEM by starting to use std::span
e363aa7 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor remaining API and all the tests to use new std::span based i…
3dab6c3 
…nterface

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
use new std::span based API for benchmarking
5c6d104 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
use static extent std::span whenever possible
8533a51 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
use span to compare shared secrets both parties arrived at
d5a534d 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update API usage example to use new std::span based API
90658ea 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
only set -march=..., instead of setting both -march=... -mtune=...
2c528a3 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update all remaining function interfaces to use statically defined `s…
5930d75 
…td::span`

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
change default compiler to clang
5eee2a8 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update project documentation to reflect latest state
ea4fd48 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan itzmeanjan merged commit a7432fa into master Oct 1, 2023
1 check passed
@itzmeanjan itzmeanjan deleted the major-api-refactor branch October 1, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itzmeanjan