Fix lit test cfg on windows. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this `str()` the test would fail with a stacktrace like this:
```shell
D:\DevLLVM\repos\mlir-tutorial\tests>lit -v .\ctlz_simple.mlir
-- Testing: 1 tests, 1 workers --
UNRESOLVED: mlir_tutorial :: ctlz_simple.mlir (1 of 1)
******************** TEST 'mlir_tutorial :: ctlz_simple.mlir' FAILED ********************
Exception during script execution:
Traceback (most recent call last):
File "C:\Wares\python310\lib\site-packages\lit\worker.py", line 76, in _execute_test_handle_errors
result = test.config.test_format.execute(test, lit_config)
File "C:\Wares\python310\lib\site-packages\lit\formats\shtest.py", line 29, in execute
return lit.TestRunner.executeShTest(
File "C:\Wares\python310\lib\site-packages\lit\TestRunner.py", line 2120, in executeShTest
script = applySubstitutions(
File "C:\Wares\python310\lib\site-packages\lit\TestRunner.py", line 1674, in applySubstitutions
output.append(unescapePercents(process(line)))
File "C:\Wares\python310\lib\site-packages\lit\TestRunner.py", line 1631, in processLine
b = b.replace("\\", "\\\\")
TypeError: Path.replace() takes 2 positional arguments but 3 were given
********************
********************
Unresolved Tests (1):
mlir_tutorial :: ctlz_simple.mlir
Testing Time: 0.16s
Unresolved: 1
```
|
Hey, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings! I'm following along your tutorial and noticed this that the test isn't working.
Without this
str()the test would fail with a stacktrace like this:I'm only running on windows with CMake though. Not sure if this is breaking other platforms.
Cheers!