-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in V2 because of badly formed OSC packages #63
Comments
Hi Thomas. Thanks for reporting. We'll look into this when I get time. I think I may have to edit the OSC library for this as I thought I had wrapped message handling on our side in try-catches (or maybe those don't catch the error). |
Hi, if you ever need any bad OSC messages I can cook up a Pure Data patch for testing! |
Hi Thomas, I started looking at this. Could you send a pd patch with bad OSC messages? Thanks! |
Here you go. Good messages do not crash VCV Rack. Bad messages do. |
Issue #63. Prevent exception from being uncaught for malformed packets.
Hi Thomas, Thanks for the file. I pushed a commit that will fix it. If you can compile from source, then it should be good to go. You can test in your real application to see how it performs. Otherwise, we will be pushing to library again after we get maybe a few more changes in. |
Hi. This has been fixed in the latest release v2.0.6 and should update in the library in the next week or so. |
Hi. Thank you so much! It seems to work great! |
Hi! Thank you for the great module! And thank you for updating it for VCV Rack 2!
I use an Arduino Nano to send OSC messages through USB Serial. The Arduino Nano is a cheap clone. This generates a few errors in the SLIP and OSC packaging. These errors are caused by hardware and are inevitable.
When I use https://github.com/RuudMulder/SlipOscBridge cvOSCcv sometimes crashes. I beleive this is because the OSC messages relayed by SlipOscBridge are sometimes malformed (as I noted in this issue : RuudMulder/SlipOscBridge#2)
Here the tail of the log:
If I instead use Pure Data to relay the OSC Slip messages, Pure Data identifies the badly formed messages and does not relay them to cvOSCcv:
While I could just use Pure Data, I think cvOSCcv should not crash if the OSC packet is malformed and just discard it.
The text was updated successfully, but these errors were encountered: