Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors for temperature graphs #40

Closed
xeddog opened this issue Sep 22, 2019 · 15 comments
Closed

Colors for temperature graphs #40

xeddog opened this issue Sep 22, 2019 · 15 comments
Labels
enhancement New feature or request
Projects
Milestone

Comments

@xeddog
Copy link

xeddog commented Sep 22, 2019

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
No problem
Describe the solution you'd like
A clear and concise description of what you want to happen.
Color changing temperature graphs for nozzle and bed temps.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Are there any????
Additional context
Add any other context or screenshots about the feature request here.
I think I would like to see color changing temperature graphs for nozzle and bed temps. Something along the lines of :
Blue when the temperature is initially set and up until the next stage
Green when the temperature is + or - 2 degrees of target temp.
RED when the temperature is + or - 5(?) degrees from the set temperature after reaching set temp and stabliizing

This could potentially show the need for running PID tune, or a potential problem coming up, etc. with just a couple of glances at the dashboard.

@StefanCohen StefanCohen added the enhancement New feature or request label Sep 22, 2019
@StefanCohen
Copy link
Collaborator

I had exactly this in mind early on and I still think it is a good idea. Take a look here: https://community.octoprint.org/t/dashboard-plugin/11536/46?u=stefan_cohen

I might give it a try after I've sorted out the fullscreen layout.

@Naugrimohtar
Copy link

How about similar for the CPU temp meaning change when getting high?

@StefanCohen
Copy link
Collaborator

@Naugrimohtar I like that but how do we define what "High" is for the CPU? Are there themal limits for the RPi specified somewhere that we can use or do we need a user setting for this?

@xeddog
Copy link
Author

xeddog commented Oct 6, 2019

Maybe this will help. From https://www.raspberrypi.org/documentation/hardware/raspberrypi/frequency-management.md

"For Raspberry Pi 3 Model B+, the PCB technology has been changed to provide better heat dissipation and increased thermal mass. In addition, a soft temperature limit has been introduced, with the goal of maximising the time for which a device can "sprint" before reaching the hard limit at 85'C. When the soft limit is reached, the clock speed is reduced from 1.4GHz to 1.2GHz, and the operating voltage is reduced slightly. This reduces the rate of temperature increase: we trade a short period at 1.4GHz for a longer period at 1.2GHz. By default, the soft limit is 60°C, and this can be changed via the temp_soft_limit setting in config.txt."

@Naugrimohtar
Copy link

Naugrimohtar commented Oct 6, 2019 via email

@StefanCohen
Copy link
Collaborator

Keep in mind that OctoPrint might just as well be running on a Xeon instead of ARM so we will need user settings for the CPU thresholds but might set them to something like 60 for yellow and 80 for red by default regardless.

The hotend and bed thresholds are different and should probably behave like @xeddog described above.

@xeddog
Copy link
Author

xeddog commented Oct 8, 2019

I didn't think about that. All the different processors would add a few thousand wrinkles, wouldn't it.

@Naugrimohtar
Copy link

Wrinkles yes but those with other platforms might not care to monitor their core temp so perhaps in addition to being able to specify the temps, we could slow enabling:disabling of that ‘widget’, and the other widgets too?

@StefanCohen StefanCohen added this to To do in TODOs Oct 8, 2019
@xeddog
Copy link
Author

xeddog commented Oct 9, 2019

But if they did care to, then the author could potentially be swamped with detailing the temperature characteristics of hundreds of processors. Maybe an option might be to let you specify your own temperatures.

@LMS0815
Copy link

LMS0815 commented Oct 9, 2019

What's about providing a user defined field for CPU?
And stick to the original idea.

Blue when the temperature is initially set and up until the next stage
Green when the temperature is + or - 2 degrees of target temp.
RED when the temperature is + (or - 5? I would regard low as OK...)

@StefanCohen
Copy link
Collaborator

StefanCohen commented Oct 12, 2019

WIP for 1.11.0:

Screenshot 2019-10-12 at 14 35 32
Screenshot 2019-10-12 at 14 37 59
Screenshot 2019-10-12 at 14 38 47

It changes to red above the critical threshold. Will work on the temp gauges next.

@StefanCohen StefanCohen added this to the 1.11.0 milestone Oct 12, 2019
@StefanCohen
Copy link
Collaborator

I added the cpu frequency to the CPU widget as that is relevant to the temp reading and throttling:

Screenshot 2019-10-12 at 15 16 53

@StefanCohen
Copy link
Collaborator

WIP:

Screenshot 2019-10-12 at 19 04 37
Screenshot 2019-10-12 at 19 04 19

There is now a setting to enable the temp gauge coloring (default off). There is also a temp deviation setting (default 10C). It works like this:

  • Blue if target = 0
  • Blue below target - deviation
  • Green between target - deviation and target + deviation
  • Red above target + deviation.

@Naugrimohtar
Copy link

Naugrimohtar commented Oct 13, 2019 via email

@StefanCohen
Copy link
Collaborator

Fixed in 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
TODOs
  
To do
Development

No branches or pull requests

4 participants