Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of long filenames #83

Closed
StefanCohen opened this issue Oct 8, 2019 · 7 comments
Closed

Better handling of long filenames #83

StefanCohen opened this issue Oct 8, 2019 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@StefanCohen
Copy link
Collaborator

Long filenames are split over several lines. Should scale the size to fit one line instead:

Screenshot 2019-10-08 at 09 36 46

@StefanCohen StefanCohen added the enhancement New feature or request label Oct 8, 2019
@StefanCohen
Copy link
Collaborator Author

StefanCohen commented Oct 8, 2019

@j7126 Do you have any idea how to scale the string dynamically to fit the containing div?

I'm thinking about using an SVG like in the last example here but that link provides a ton of alternatives and there may be a better method that I'm not aware of. What do you think? Is this the kind of situation you would use a viewport width instead?

@j7126
Copy link
Owner

j7126 commented Oct 8, 2019

@StefanCohen I would say that using a svg in most situations would be fine, however in this case the text color if using a svg will not play nice with themes,

I think that for this situation using viewport width would be much better.
EDIT: this is not true, see my next comment

@j7126
Copy link
Owner

j7126 commented Oct 8, 2019

I realised my mistake that using viewport width will actually not be a good idea and will not work because that works for things that take up the whole page, and the dashboard when not in fullscreen mode does not take up the entire screen.

I think it would be much better in this case to use fitty https://github.com/rikschennink/fitty which was also mentioned in that link and I have used in the past and works well.

@StefanCohen
Copy link
Collaborator Author

Thanks. Fitty looks like a nice alternative. I will give it a try.

@StefanCohen
Copy link
Collaborator Author

StefanCohen commented Oct 8, 2019

That worked fine:
Screenshot 2019-10-08 at 12 30 22

I wonder where something like this should be called from? I temporarily placed it in the self.onTabChange callback handler sice it is called on print start but that doesn't seem right. There is no callback for .onPrintStart so I guess it has to be a new event handler for PrintStarted? What do you think?

Edit: No. It has to be called anytime there is a change to the container (such as going to fullscreen).

@StefanCohen
Copy link
Collaborator Author

Nvm. I'm just slow. I got it now :)

StefanCohen pushed a commit that referenced this issue Oct 8, 2019
…er count not correct in dashboard but in DisplayLayerProgress
@StefanCohen StefanCohen added this to the 1.10.2 milestone Oct 8, 2019
@StefanCohen
Copy link
Collaborator Author

Fixed in v1.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants