Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Pause & Cancel #87

Closed
retikulumx opened this issue Oct 8, 2019 · 7 comments
Closed

Feature Request - Pause & Cancel #87

retikulumx opened this issue Oct 8, 2019 · 7 comments
Labels
enhancement New feature or request
Projects
Milestone

Comments

@retikulumx
Copy link

It would be cool, if you could implement the "Pause" and "Cancel" button. I'm using an old tablet as display for my printer. But sometimes I have to interrupt the print.
Thanks :-)

@retikulumx retikulumx changed the title Feature Request Feature Request - Pause & Cancel Oct 8, 2019
@StefanCohen StefanCohen added the enhancement New feature or request label Oct 8, 2019
@StefanCohen
Copy link
Collaborator

So I guess you are using it in fullscreen mode on the tablet?

I have already added support for pause/cancel, but it is only available via a context menu by clicking on the file name. I guess that is a no-go on a tablet...

@StefanCohen StefanCohen added this to To do in TODOs Oct 8, 2019
@retikulumx
Copy link
Author

Hi.
Yes, exactly. I'm using it in full screen mode.
Would be very comfortable to place 2 buttons directly to the screen.
But maybe the "cancel" button with a "are you really sure" prompt. If that's not possible, the pause button should be enough I guess.

@StefanCohen
Copy link
Collaborator

StefanCohen commented Oct 12, 2019

WIP:

Screenshot 2019-10-12 at 10 01 31

The three buttons are a copy of the sidebar buttons and should work the same. This means that you can start a job by pressing print given that a file is selected. The pause button toggles to Resume when the job is paused. Cancel is clickable when a job is running.

@j7126 There is a slight problem with the cancel confirmation modal dialog. It is not displayed on top of the fullscreen element so it is hidden until I exit fullscreen. Do you have any ideas how to solve that? I guess it has to be done from js but I haven't found a way yet.

StefanCohen pushed a commit that referenced this issue Oct 12, 2019
@StefanCohen StefanCohen added this to the 1.11.0 milestone Oct 12, 2019
@j7126
Copy link
Owner

j7126 commented Oct 13, 2019

@StefanCohen the reason that the confirmation dialog is hidden in fullscreen is because since you are just duplicating the default buttons and confirmation dialog which is part of octoprint, this dialog is outside of the dashboard element. Because only the dashboard element is what is fullscreen that is why this is happening.

I will work on a solution.

@j7126
Copy link
Owner

j7126 commented Oct 13, 2019

@StefanCohen fixed in #94

@StefanCohen
Copy link
Collaborator

Confirmed fixed in #94. Thanks again!

@StefanCohen
Copy link
Collaborator

Fixed in 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
TODOs
  
To do
Development

No branches or pull requests

3 participants