-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple question: How do I get back out of Full Browser Mode in 1.11.0 release? #96
Comments
You get out of it by clicking on the full browser icon again or by pressing the back button in the browser. I have tested this in the latest version of Chrome, Firefox and Safari on Mac. What browser/OS are you using? |
Latest version of Chrome. The back button brings me back to the previous tab view, but clicking on the dashboard tab goes right back to Full Browser mode, not integrated mode. Clicking the full browser button again doesn't reverse the setting for me. The only way I was able to get it back to normal integrated mode was to manually type in the ipaddress/#tab_plugin_dashboard address, removing the /?dashboard=full portion of the address. |
Pretty strange. I can switch seamlessly between the integrated, full browser and full screen modes using the icons, esc and the browser back button in all three browsers i mentioned above. |
That is odd. Esc works as expected for full screen mode, but nothing works for me to reset full browser mode back to integrated mode except manually removing the ?dashboard=full portion of the address. |
Can you try emptying the browser cache? |
I just realized that there probably is one thing I can do to force the browser to behave when pressing the icon again to get out of full browser mode. It is getting late here but I will give that a go tomorrow morning. |
Clearing the cache unfortunately doesn't change the behavior for me. |
Try this. Change Line 73 in dashboard.js to:
Then reload the page and try switching to and back from full browser mode using the icon. |
In the interest in providing as much detail as I can here is some more info about my set up. I'm running OctoPrint on an Ubuntu 19.04 installation on an Intel box. I've installed all plugins through the plugin manager so they are stored as packaged plugins in the packed_plugins.js. I changed the line you referenced as you described but it did not change the behavior even after restarting OctoPrint. I've tested this on 2 different computers with both Chrome and Firefox on each. The behavior I describe is consistent and the only way I can get rid of full browser mode is to manually delete "?dashboard=full" from the address bar. This really isn't a huge problem for me, but I assume you would prefer it work as you intended. I hope this provides some help in troubleshooting |
I appreciate it and it does provide valuable feedback. My problem right now is that I can't reproduce it no matter how hard I try. I have three separate RPis. One for development, one for testing and one for my printer. I also have a a machine running Ubuntu 18.04 that I do OctoPrint testing on in addition to the RPIs. I have five different browsers across both win and osx machines and no combination of host/client shows the problem as you describe it so far. The line change you did should remove that "?dashboard=full" from the address bar for you and I'm a bit concerned that it does not. It points to two possibilities: Either the change is not applied, or something is caching the requests. Do you by any chance run OctoPrint behind some kind of proxy server? That could explain the problem. |
No proxy. I do some software development too and can understand the dilemma of not being able to reproduce a problem to troubleshoot it. I really don't have a very unique setup other than running it on an Intel based Ubuntu platform. Based upon that, I can't understand how I'd be the only one experiencing this issue, but if I am it isn't that big of a deal for me and really doesn't hamper my use of Dashboard much at all. I'll try to dig a little deeper when I have a chance and see if I can come up with any other tidbits that might help identify why this is happening. I have a second, identical OctoPrint box connected to another Prusa Bear Mk3s. It has not been updated with your latest release because it's in the middle of a rather long print. I'll see if it reacts differently, or the same, once that prints finishes (currently slated to finish late tonight). |
There is now at least one other user who has this problem so you are not alone. I have made some changes that may fix this for you but I can't verify it myself. The changes are not in any release yet so please try it by installing via the plugin manager directly from this URL: https://github.com/StefanCohen/OctoPrint-Dashboard/archive/master.zip |
I installed your update from the link provided. Dashboard does now goes back to the regular integrated mode as would be expected in both Chrome and Firefox. It appears you found the issue, at least in my case. One other thing with Full Browser mode. When in integrated browser mode clicking on the full browser button flashes a black screen with a "Please wait" message then goes back the the integrated view. Hitting the Full Browser mode button again a second time will then open Full Browser mode. It always takes 2 hits of the button to get it to eventually go into that mode, with the black please wait screen in between. This is with both Chrome and Firefox, and is the case with both this pre-released fixed version as well as the previous released version. |
Ok. I'm glad that fixed at least that issue but again, that second behaviour is not something I see here. It will always go directly to the selected mode for me. I will dig some more... Btw, are you using a different tab order than default? |
Thanks. I will have to install Tab Order again and see if that is causing the problem. |
Attempted fix in 1.11.1 |
I clicked on the Full browser mode and don't seem to be able to get it to go back to integrated browser mode.
The text was updated successfully, but these errors were encountered: