Do not fade when fadeOut is zero #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-run
pushed a commit
to p-run/simplecov-html
that referenced
this pull request
Mar 8, 2015
Forward animation is disabled already, but colorbox fades its closing which results in animation when navigating backwards. Requires jackmoore/colorbox#701 for colorbox to properly handle zero fadeOut value.
p-run
pushed a commit
to p-run/simplecov-html
that referenced
this pull request
Mar 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fadeTo executes a fade even when fadeOut value is zero, hence, check for zero value explicitly and do not fade in this case.