Pass accessibility tests. fixes #765 #821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach here adds button text from colorbox defaults at page
load time to avoid the following errors reported by accessibility
tests:
* wave.webaim.org:
A button is empty or has no value text.
* HTML_CodeSniffer WCAG 2.0 Level AAA:
This button element does not have a name available to an
accessibility API. Valid names are: title attribute, element
content.
jameswilson
added a commit
to BluesparkLabs/colorbox
that referenced
this pull request
Mar 28, 2017
This is a formal approach to fixing jackmoore#765 with proper use of Aria attributes as an alternative to PR jackmoore#821. Changes include: * Add `aria-hidden` attributes on the dialog box and navigational buttons. * Update the `aria-hidden` value to `true` or `false` at the appropriate times. * Add `aria-label` attributes to navigational buttons, using the colorbox default settings at page load time, and then update the value when a colorbox is loaded. * Add `aria-labelledby` and `aria-describedby` attributes to the div containing `role='dialog'`.
This was referenced Mar 28, 2017
|
#822 is the better solution at this point. closing. |
cdubz
added a commit
to CascadePublicMedia/colorbox
that referenced
this pull request
Dec 14, 2021
* Aria Accessibility compliance. fixes jackmoore#765 This is a formal approach to fixing jackmoore#765 with proper use of Aria attributes as an alternative to PR jackmoore#821. Changes include: * Add `aria-hidden` attributes on the dialog box and navigational buttons. * Update the `aria-hidden` value to `true` or `false` at the appropriate times. * Add `aria-label` attributes to navigational buttons, using the colorbox default settings at page load time, and then update the value when a colorbox is loaded. * Add `aria-labelledby` and `aria-describedby` attributes to the div containing `role='dialog'`. * Pass HTML_CodeSniffer WCAG 2.0 tests * Cleanup unneeded aria-labels, fix autoreading of dialog by using ARIA live regions and ensure focus is on the first element in the dialog when it opens * Fix spelling of 'aria-label' * Cleanup unneeded aria-labels, fix autoreading of dialog by using ARIA live regions and ensure focus is on the first element in the dialog when it opens * Reworked focus trapping * Updated minified version Co-authored-by: James Wilson <[email protected]> Co-authored-by: <[email protected]> Co-authored-by: Bram Duvigneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is option 1 fix for #765.
The approach here adds button text from colorbox defaults at page load time to avoid the following errors reported by accessibility tests:
wave.webaim.org:
HTML_CodeSniffer WCAG 2.0 Level AAA: