Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed a singleton-comparison pitfall #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NaelsonDouglas
Copy link

@NaelsonDouglas NaelsonDouglas commented Oct 10, 2021

Problem:
The code had a pitfall known as singleton-comparison.
In Python, when comparing singletons, like None, True or False, it's safer to use the 'is' operator instead of '=='.
Constructions like:

foo == True
bar == False
foobar == None

Are preferred to be written as:

foo is True
bar is False
foobar is None

These discussions give some highlight into this topic
https://stackoverflow.com/questions/1011431/common-pitfalls-in-python
https://stackoverflow.com/questions/2209755/python-operation-vs-is-not

Solution:
This pull request simply removes this pitfall from the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant